neo-project / neo-node

MIT License
229 stars 224 forks source link

Get plugin network #856

Closed Jim8y closed 2 years ago

Jim8y commented 2 years ago

Allow users to check the plugin network configuration

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2144116889


Totals Coverage Status
Change from base Build 2113590274: 0.0%
Covered Lines: 107
Relevant Lines: 683

💛 - Coveralls
erikzhang commented 2 years ago

Some plugins support multiple networks. For example, RpcServer.

Jim8y commented 2 years ago

Some plugins support multiple networks. For example, RpcServer.

OOOOOOK, need more work on them then~~~~

erikzhang commented 2 years ago

And why do we need this command?

Jim8y commented 2 years ago

And why do we need this command?

Cause it is hard to figure out what is happening when you have everything right but the node never run correctly, just like what is mentioned here https://github.com/neo-project/neo-node/issues/824#issuecomment-1090464930

It is annoying to check network configs of plugins one by one. Especially when users have to work among different network modes, like switch between mainnet and testnet regularly.

erikzhang commented 2 years ago

If you can think of using this command, then you must have realized what the problem is, then this command is useless.

Jim8y commented 2 years ago

I would say, locating issue with one command is way batter than "get into multiple plugins, open their config.json files, then compare the network cross multiple files". Cli is supposed to make things easier right?

I know how tough it could be cause once I had to deal with 7 nodes on my local machine, with each node 4 plugins.