neo-project / neo-node

MIT License
229 stars 223 forks source link

delete plugin folder when uninstall plugin #860

Closed Jim8y closed 2 years ago

Jim8y commented 2 years ago

Correspond to https://github.com/neo-project/neo/pull/2696

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2208503501


Totals Coverage Status
Change from base Build 2186768199: 0.0%
Covered Lines: 107
Relevant Lines: 683

💛 - Coveralls
shargon commented 2 years ago

Tested @superboyiii ?

erikzhang commented 2 years ago

Need to test.

Jim8y commented 2 years ago

Need to test.

@nicolegys ~~~ may you please help me test this?

nicolegys commented 2 years ago

Need to test.

@nicolegys ~~~ may you please help me test this?

I'll test it.

nicolegys commented 2 years ago

Need to test.

@nicolegys ~~~ may you please help me test this?

I'll test it.

Sorry, I can't test it now. The master branch of neo-modules is incompatible with neo-3.2.1-CI01365.

Jim8y commented 2 years ago

@nicolegys https://github.com/neo-project/neo-modules/pull/713 is merged, we can test this pr now

nicolegys commented 2 years ago

plugin can be uninstalled even though others depend on it. 1653909444(1) seems something wrong when reading config.json image

Jim8y commented 2 years ago

Seems the dependency check failed, i will check it out @nicolegys

Jim8y commented 2 years ago

@nicolegys fixed

erikzhang commented 2 years ago

@nicolegys Can you test it again?

nicolegys commented 2 years ago

plugin can be uninstalled even though others depend on it. 1653909444(1) seems something wrong when reading config.json image

This issue still exists. @Liaojinghui

Jim8y commented 2 years ago

@nicolegys that is because you did not use the correct plugin name, original plugin name is not ALL lowercases.

nicolegys commented 2 years ago

@nicolegys that is because you did not use the correct plugin name, original plugin name is not ALL lowercases.

You are right! But since both install and uninstall support ignoring case, we'd better maintain consistency.