neo-project / proposals

NEO Enhancement Proposals
Creative Commons Attribution 4.0 International
136 stars 113 forks source link

Debug Info NEP #140

Closed devhawk closed 2 years ago

devhawk commented 2 years ago

This NEP has been accepted and it's ready to merge. I'm working on v2 of this format as part of Storage Schema so it would be useful for me to get v1 merged ASAP.

Not sure who has review/commit privileges, so ccing some folks who've committed to this repo: @erikzhang @shargon @roman-khimov @superboyiii @bettybao1209

devhawk commented 2 years ago

ping @erikzhang @shargon @roman-khimov @superboyiii @bettybao1209

erikzhang commented 2 years ago

This NEP has been accepted and it's ready to merge. I'm working on v2 of this format as part of Storage Schema so it would be useful for me to get v1 merged ASAP.

Why don't we just go straight to v2?

devhawk commented 2 years ago

Why don't we just go straight to v2?

V2 isn't ready yet. I just put the debugger that parses v2 into preview a couple days ago. No other compiler beyond a fork of NCCS emits the V2 format yet. I don't feel comfortable finalizing that until there's at least two compilers generating it and it's out of preview.

I can open a V2 draft PR as soon as V1 is merged.

devhawk commented 2 years ago

Ping @erikzhang

erikzhang commented 2 years ago

@devhawk Can you convert the .md file to .mediawiki? Because GitHub won't generate Table of Contents for .md files automatically.

devhawk commented 2 years ago

@devhawk Can you convert the .md file to .mediawiki? Because GitHub won't generate Table of Contents for .md files automatically.

Done

devhawk commented 2 years ago

I don't have merge rights