search

neo-project / proposals

NEO Enhancement Proposals
Creative Commons Attribution 4.0 International
136 stars 113 forks source link

onNEP17Payment Callback Method Standard for NEO Smart Contracts #167

Closed Jim8y closed 6 months ago

Jim8y commented 7 months ago

This pr focus on making the onNEP17Payment method an NEP standard, such that user can declare their contract as payable and we can verify this method in our tools.

This nep is backwards compatible, not a single smart contract or standards need to be updated.

Jim8y commented 7 months ago

@roman-khimov told ya I can't write formal document, need you to do it. Open this pr to get a place for further discussion. Will close this one when you decide to write a formal one.

Jim8y commented 7 months ago

BTW, I am not rushing, I just don't know how. LOL.

roman-khimov commented 7 months ago

Will close this one when you decide to write a formal one.

You've opened a PR. To me this means "I'm working on it with the goal to have it accepted eventually" (which includes fixing any problems and making it a real good standard). If that's the case, I'm more than happy to not do this because I have a pretty long TODO list (I will review/comment on it of course to help you). If that's not the case then I don't really understand why we have this PR. Issues are better suited for discussions.

Jim8y commented 7 months ago

Will close this one when you decide to write a formal one.

You've opened a PR. To me this means "I'm working on it with the goal to have it accepted eventually" (which includes fixing any problems and making it a real good standard). If that's the case, I'm more than happy to not do this because I have a pretty long TODO list (I will review/comment on it of course to help you). If that's not the case then I don't really understand why we have this PR. Issues are better suited for discussions.

Sure, I will open an issue and close this pr. Thank you very much for your help.

Jim8y commented 6 months ago

wait for roman to draft a standard version