search

neo-project / proposals

NEO Enhancement Proposals
Creative Commons Attribution 4.0 International
136 stars 113 forks source link

We need LP Tokens #175

Open cschuchardt88 opened 2 months ago

cschuchardt88 commented 2 months ago

We need a way to id LP tokens on the network. There is many reasons why to have this.

Like https://eips.ethereum.org/EIPS/eip-7621

Jim8y commented 2 months ago

Expect 3 years.

EdgeDLT commented 2 months ago

I don't want to say it's not useful, but I'm not following why this is necessary. What does ERC-7621 have to do with needing a standard to ID LP tokens? It doesn't use one. Does Ethereum even have such a standard? I've never heard of it.

I can't imagine a competent dApp developer using any kind of automatic aggregation when building token baskets or similar protocols that might use LP tokens. Sounds like a great way to get exploited.

cschuchardt88 commented 2 months ago

https://eips.ethereum.org/EIPS/eip-5115

roman-khimov commented 2 months ago

I'm not sure why we have it here. Does it require any changes to the core? I don't think so. It's something for proposals. Then interested parties (that actually do these things and I doubt it's core developers, it's more like Flamingo developers) can come up with something if they need to.

cschuchardt88 commented 2 months ago

Well all the current LP tokens violate NEP-17 any ways. Shouldn't even have NEP-17 as a "supported" in their contract.