search

neo09 / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Consider making all PresenterWidget and Presenter members private #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Some members in PresenterWidget and Presenter are protected now. For example, 
PresenterWidget.view or PresenterWidget.visible.

These should probably be made private (or default) so that the user is forced 
to use accessors. This could cause issues with testing, however. For example,  
their might not be an easy way to make a PresenterWidget visible without 
manually setting the member.

Original issue reported on code.google.com by philippe.beaudoin on 10 Jun 2010 at 5:08

GoogleCodeExporter commented 9 years ago 
I like it. think also to offer enough accessors like for eventBus in 
PlaceManagerImpl. For your testing problem, maybe including some testing helper 
in the same package and so using default visibility.

Original comment by olivier....@free.fr on 10 Jun 2010 at 10:04

GoogleCodeExporter commented 9 years ago

Original comment by goudreau...@gmail.com on 12 Aug 2010 at 8:24

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/gwt-platform/source/list?r=cb1d7bd72c4f5c181223ff6ba345
1b056c7ea353 for code review.

Original comment by goudreau...@gmail.com on 12 Aug 2010 at 10:09

GoogleCodeExporter commented 9 years ago

Original comment by goudreau...@gmail.com on 13 Aug 2010 at 9:55