search

neo4j-contrib / graphgist-cms

http://graphgist.neo4j.com/
67 stars 24 forks source link

Manage Page Deletes GraphGist Content #43

Open jexp opened 9 years ago

jexp commented 9 years ago

Several fields of the graphgist node are overriden or removed by the manage/approval page.

At least author / twitter, possibly more.

cheerfulstoic commented 9 years ago

Ouch, that's not good. I'll look at that now!

cheerfulstoic commented 9 years ago

I'm not able to reproduce this locally. I submitted a new graphgist and changed it's status to live, but everything still seems to be there...

jexp commented 9 years ago

I had it here: http://graphgist.neo4j.com/#!/gists/26406a0e4c8e924958c2ebeea6f36455/summary (via this: http://graphgist.neo4j.com/#!/gists/manage/26406a0e4c8e924958c2ebeea6f36455) and here http://graphgist.neo4j.com/#!/gists/eab6dca75f701444987d709f4b0217e1/summary

cheerfulstoic commented 9 years ago

Ah, that makes me feel somewhat better. The missing fields there are missing because the fields submitted via twitter aren't the same as those. Going field by field:

Rating: I'm not sure where these values came from. Can I drop this? Domains/Use Cases: I'll only show these fields when they have values (the users of both gists just happen to submit only domains / only use cases but not both) Authored By: I just need to create a separate node here rather than store the values on the Gist node Keywords: We don't offer a way for users to submit these currently

cheerfulstoic commented 9 years ago

Ok, it's now hiding domains/use cases when not there. Also on submit a separate Person node is being created and linked to the gist.

Should the E-Mail field be required? Currently I'm doing a MERGE or twitter and email to see if there's already a Person there (not perfect, but I couldn't think of a way to do a merge on one or the other)

cheerfulstoic commented 9 years ago

I've made the E-Mail required for now because otherwise the submission form will break if somebody doesn't enter one.

I've also fixed the four gists which have already been submitted to give them associated Person nodes