take the intersection of spec properties and node properties for index requests

neo4j-contrib / neo4j-elasticsearch

Neo4j ElasticSearch Integration

Apache License 2.0

210 stars 79 forks source link

take the intersection of spec properties and node properties for index requests #13

Closed smackesey closed 8 years ago

smackesey commented 9 years ago

fixes #12

I am not a Java programmer so I don't know whether my code here is breaking any best practices. It does appear to work though. All I did was take the set intersection of a node's existing properties and the spec properties before adding to the index request list. I do not have time to grok the test API right now so I haven't written a test. Also, there is no existing test for beforeCommit.

alank64 commented 8 years ago

I was a Java developer but the void of 7 years of it has left me.. well void! ;-)

Just my two cents, I think this PR fixes a lot of severe issues with this plugin, and it's a really good start towards ignoring the non-provided properties, I've struggled with this a lot in master, even having to change the models to accommodate the limitations. I would vote up to pull this into the main branch, then encourage more discussions on the handling of properties or lack of.