search

neo4j-contrib / neo4j-elasticsearch

Neo4j ElasticSearch Integration
Apache License 2.0
210 stars 79 forks source link

Add SSL Support #19

Closed leviwilson closed 8 years ago

leviwilson commented 8 years ago

Description

With the current version of the plugin it does not support SSL. If you have an SSL endpoint it is able to discover the nodes, but when it tries to do anything with them it fails because it is using the incorrect schema (defaults to http://).

This PR adds the ability to check the schema so it can set the defaultSchemeForDiscoveredNodes to whatever is passed into the hostName in the configuration.

Additionally, there is a synchronous / asynchronous HTTPS handler that you have to add for this to work as well (as noted in the Jest README. I would like to not have to turn off the validation of the SSL certificate, however I do not believe that the DNS name is ever used from the http_address and it only uses the IP address as I have noted here.

leviwilson commented 8 years ago

Note that this also fixes #18.

leviwilson commented 8 years ago

I've added searchbox-io/Jest#328 to touch on not being able to have operations using the DNS name (rather than IP) which forces us to turn of SSL verification.

jexp commented 8 years ago

Merged manually, thanks a lot.