search

neo4j-contrib / neo4j-helm

Helm Charts for running Neo4j on Kubernetes [DEPRECATED]
https://neo4j-contrib.github.io/neo4j-helm/user-guide/USER-GUIDE.html
Apache License 2.0
88 stars 81 forks source link

Set default SecretName to null so it can be used as subchart without … #200

Closed alemairebe closed 3 years ago

alemairebe commented 3 years ago

Hi @eastlondoner ,

I run into the same issue as https://github.com/neo4j-contrib/neo4j-helm/pull/199 when trying to use the main chart without secrets storing credentials. The proposed solution is simply to set the value to null. Looking at deployment-scenarios it should be OK as they all set there own value for that key. I assume it will be the same for other users of this chart.

eastlondoner commented 3 years ago

Hi @alemairebe I think this could technically break things if someone is relying on the default setting.

However we are about to do a 4.3.0 release and I think we could tolerate breaking things when we do that.

eastlondoner commented 3 years ago

This was cherry-picked into the 4.3.2-1 release. Thanks you for the contribution