search

neo4j-contrib / neoclipse

Graph Database Tool
219 stars 136 forks source link

Icon location #38

Open pducrot opened 11 years ago

pducrot commented 11 years ago

Hi, I'm currently working on allowing database relative path for icon location. At the moment, if one set a relative path, it points to eclipse directory, I'd prefer to have it pointing to the database directory and therefore be different for each database. I use neo4j in computational chemistry, hence most of my nodes are molecules or fragments represented by their molecular structure stored as png files. My database upload protocol usually stores those in an images directory in the neo4j database directory. This might not be the best practice, but it actually make sense to me to store all files in the same location.

This implementation may have important impact on the current code and other people use of neoclipse. Therefore, before going any further I'd like to have your comments on this. Cheers,

peterneubauer commented 11 years ago

Could we maybe have some ${db_dir } path variable to indicate location?

/peter

Sent from mobile device. On Dec 23, 2012 10:56 AM, "Pierre" notifications@github.com wrote:

Hi, I'm currently working on allowing database relative path for icon location. At the moment, if one set a relative path, it points to eclipse directory, I'd prefer to have it pointing to the database directory and therefore be different for each database. I use neo4j in computational chemistry, hence most of my nodes are molecules or fragments represented by their molecular structure stored as png files. My database upload protocol usually stores those in an images directory in the neo4j database directory. This might not be the best practice, but it actually make sense to me to store all files in the same location.

This implementation may have important impact on the current code and other people use of neoclipse. Therefore, before going any further I'd like to have your comments on this. Cheers,

— Reply to this email directly or view it on GitHubhttps://github.com/neo4j/neoclipse/issues/38.

pducrot commented 11 years ago

It's an idea. Also thought about having some radio button to chose between full path, eclipse relative or db relative path, but it's yet to complicated for me as far as I got into the code, may be later.

peterneubauer commented 11 years ago

Why not implement the standard url scheme, which supports both relative, absolute and remote locations?

/peter

Sent from mobile device. On Dec 23, 2012 11:18 AM, "Pierre" notifications@github.com wrote:

It's an idea. Also thought about having some radio button to chose between full path, eclipse relative or db relative path, but it's yet to complicated for me as far as I got into the code, may be later.

— Reply to this email directly or view it on GitHubhttps://github.com/neo4j/neoclipse/issues/38#issuecomment-11644764.

pducrot commented 11 years ago

I guess that's what exists, the question I raise is relative to what. So far, it's relative to eclipse, I'd like to make it relative to the database so that you don't have to change preferences each time you open a database. At the moment, if one types a relative path, say "images" in the preference panel, it creates a directory in the Eclipse directory.