search

neo4j-contrib / neoclipse

Graph Database Tool
218 stars 136 forks source link

Enable CLI builds with Eclipse Tycho #53

Closed manandbytes closed 10 years ago

nawroth commented 10 years ago

@manandbytes This looks great! Didn't know Tycho was up to this (again).

Some input:

To merge the PR, we need a CLA, see: http://docs.neo4j.org/chunked/snapshot/cla.html

The packaging needs some work:

We do have the org.neo4j.neoclipse/package.sh script which could be modified. Or we could just use a different mvn plugin for the packaging part. Doesn't look like the one in use offers a lot of packaging options.

We shouldn't build distributions for platforms where we have no intention on testing them. I'd say, stick to:

If someone steps up to do the testing, we could add more platforms. Not sure about hpux, but at least, it's among the supported platforms for Neo4j itself so it makes sense to build it.

manandbytes commented 10 years ago

@nawroth, thanks for comments

To merge the PR, we need a CLA

Done. I'd like to squash/rebase commits before merge.

The packaging needs some work

Will take a look.

nawroth commented 10 years ago

Ok, confirming that the CLA is in.

Squashing commits is what we usually do.

Just tell us if you have any questions regarding the packaging part. Because of the EPL vs GPL mismatch, including the full license info in the packages is crucial.

manandbytes commented 10 years ago

@nawroth It's almost done, could you take a look?

The last thing to fix is missing icons, like:

[INFO] --- tycho-p2-publisher-plugin:0.19.0:publish-products (default-publish-products) @ repository ---
java.io.FileNotFoundException: /home/travis/build/manandbytes/neoclipse/repository/target/products/neoclipse/org.neo4j.neoclipse/icons/obj16/neo-48.xpm (No such file or directory)
nawroth commented 10 years ago

@manandbytes Great work on the packaging!

manandbytes commented 10 years ago

@nawroth There are still no icons for Windows launchers, due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=384509:

[INFO] --- tycho-p2-publisher-plugin:0.19.0:publish-products (default-publish-products) @ repository ---
Error - 7 icon(s) not replaced in /tmp/p2.brandingIron4544998212125010483/launcher.exe using /home/travis/build/manandbytes/neoclipse/repository/target/products/neoclipse/icons/obj16/neo.ico
Error - 7 icon(s) not replaced in /tmp/p2.brandingIron6508182884875601395/launcher.exe using /home/travis/build/manandbytes/neoclipse/repository/target/products/neoclipse/icons/obj16/neo.ico

As I understand (but not 100% sure), it requires switching to Kepler (building Kepler-based product).

nawroth commented 10 years ago

Not worth it trying to fix the launcher icons under windows. At least, the application icon works, so pinning Neoclipse to the taskbar (or whatever it's called) looks perfect in Windows 8, I just tried that.

I suggest this roadmap for the near future of Neoclipse:

WDYT @manandbytes @peterneubauer @jexp @nrkkaylan ?

manandbytes commented 10 years ago

When you squash the commits, we merge this PR.

Not sure if it makes sense to squash them further:

> git log --reverse --oneline origin/master..manandbytes/tycho
50cfa19 Enable Travis CI builds
372ef19 Default target platform
e9d0af8 Build with Tycho
52aa3e0 Build product
cf28291 Extract LICENSE.txt, NOTICE.txt and README.txt from org.neo4j.neoclipse bundle
0ddba4f Place LICENSE.txt, NOTICE.txt and README.txt into every product
nawroth commented 10 years ago

Sorry @manandbytes, I didn't notice the commits very already squashed together!

nawroth commented 10 years ago

@manandbytes Thanks a lot, having CLI builds for Neoclipse is a huge improvement. Awesome you managed to nail so many details at once!