search

neo4j-contrib / neomodel

An Object Graph Mapper (OGM) for the Neo4j graph database.
https://neomodel.readthedocs.io
MIT License
939 stars 231 forks source link

Make slicing return a NodeSet. #677

Closed tonioo closed 1 year ago

tonioo commented 1 year ago

According to documentation: https://neomodel.readthedocs.io/en/latest/queries.html?highlight=count#iteration-slicing-and-more

Slicing a NodeSet is supposed to return a NodeSet so it allows us to continue chaining calls.

The current implementation is actually returning a list. This fix is an attempt to make code consistent with documentation.

aanastasiou commented 1 year ago

@tonioo great catch, thank you for your contribution.

tonioo commented 1 year ago

@aanastasiou You're welcome, thank you for maintaining neomodel. What are the criteria to respect before such PR can be merged into master branch?

aanastasiou commented 1 year ago

@tonioo All PRs from all contributors no matter how small or large are reviewed for inclusion in upcoming releases. We have a few changes queued for the next relase which might be within the next month (maybe sooner).

tonioo commented 1 year ago

@aanastasiou Ok, thank you for the answer.