Closed aanastasiou closed 1 year ago
Adds the following test fail :
Merged the conflict because it was my fault. I accidentally removed the logger in rc branch when I removed the "neo4j" log watcher
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Merging #738 (3196f29) into rc/5.1.1 (f3eb90b) will increase coverage by
0.22%
. The diff coverage is97.77%
.
@@ Coverage Diff @@
## rc/5.1.1 #738 +/- ##
============================================
+ Coverage 85.92% 86.14% +0.22%
============================================
Files 18 19 +1
Lines 2366 2397 +31
============================================
+ Hits 2033 2065 +32
+ Misses 333 332 -1
Files Changed | Coverage Δ | |
---|---|---|
neomodel/relationship.py | 97.22% <ø> (ø) |
|
neomodel/util.py | 90.25% <95.45%> (+0.28%) |
:arrow_up: |
neomodel/__init__.py | 100.00% <100.00%> (ø) |
|
neomodel/path.py | 100.00% <100.00%> (ø) |
Addresses shortcomings of 716.
Path failed to instantiate properly, on this line, when relationships that were not association classes were passed to it. This is because, those relationships do not have data and therefore do not have an entry in
_NODE_CLASS_REGISTRY
. That lookup failed (unfortunately silently) and resulted in aPath
object with "unresolved"nodes, relationships
. This was corrected to produce aStructuredRel
in that case. All objects (whether relationship or node) load exactly once.