search

neo4j-contrib / neomodel

An Object Graph Mapper (OGM) for the Neo4j graph database.
https://neomodel.readthedocs.io
MIT License
936 stars 231 forks source link

Incorrect query for count of objects #769 #771

Closed mariusconjeaud closed 8 months ago

mariusconjeaud commented 8 months ago

Issue was when count was used in combination with skip/limit.

Had to change the query builder so that pagination happens to variables before the count aggregation is applied.

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (300402f) 89.28% compared to head (0c12b42) 89.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## rc/5.2.1 #771 +/- ## ============================================ + Coverage 89.28% 89.39% +0.11% ============================================ Files 22 22 Lines 2651 2660 +9 ============================================ + Hits 2367 2378 +11 + Misses 284 282 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OlegGustilov commented 8 months ago

Thank you for the fix! I tested it with Django and it works good!