fix(core): compare objects by id in memory if they are different

neo4j-contrib / neomodel

An Object Graph Mapper (OGM) for the Neo4j graph database.

https://neomodel.readthedocs.io

MIT License

936 stars 231 forks source link

fix(core): compare objects by id in memory if they are different #780

Closed OlehChyhyryn closed 4 months ago

OlehChyhyryn commented 7 months ago

github: [https://github.com/neo4j-contrib/neomodel/issues/778](Structured Node eq works incorrectly for non-persisted nodes.)

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

OlehChyhyryn commented 7 months ago

Something weird with tests

mariusconjeaud commented 4 months ago

Tested with the new async code (merge in rc/5.3.0) and it works just fine.

So I will merge this into a temp branch (rc/5.3.0-pre), so I can merge it back into the actual release candidate branch. This is because I otherwise need to just copy paste your code as the async and sync codebases are now split, and you won't be seen as a contributor anywhere :-)

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud