neo4j-contrib / neomodel

An Object Graph Mapper (OGM) for the Neo4j graph database.
https://neomodel.readthedocs.io
MIT License
936 stars 231 forks source link

Add async support to neomodel #783

Closed mariusconjeaud closed 4 months ago

mariusconjeaud commented 7 months ago

Introducing support for asynchronous programming to neomodel required to introduce some breaking changes:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 91.46730% with 214 lines in your changes are missing coverage. Please review.

Project coverage is 82.02%. Comparing base (4bd6302) to head (8bd7aa0).

:exclamation: Current head 8bd7aa0 differs from pull request most recent head ce3a1cf. Consider uploading reports for the commit ce3a1cf to get more accurate results

Files Patch % Lines
neomodel/async_/match.py 90.16% 54 Missing :warning:
neomodel/async_/core.py 93.43% 42 Missing :warning:
neomodel/sync_/core.py 93.43% 42 Missing :warning:
neomodel/contrib/async_/semi_structured.py 26.47% 25 Missing :warning:
neomodel/contrib/spatial_properties.py 9.09% 20 Missing :warning:
neomodel/async_/relationship_manager.py 92.01% 19 Missing :warning:
neomodel/sync_/match.py 90.00% 3 Missing :warning:
neomodel/async_/relationship.py 97.59% 2 Missing :warning:
neomodel/scripts/neomodel_install_labels.py 0.00% 2 Missing :warning:
neomodel/scripts/neomodel_remove_labels.py 0.00% 2 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## rc/5.3.0 #783 +/- ## ============================================ - Coverage 89.43% 82.02% -7.41% ============================================ Files 22 32 +10 Lines 2669 4429 +1760 ============================================ + Hits 2387 3633 +1246 - Misses 282 796 +514 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mariusconjeaud commented 5 months ago

!!!!!!! The integration tests pipeline was fully successful for the first time since starting the work on async !!!!!!!

It should be ready soon !

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
16.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud