Unit test failures: billesholm.osm file is missing and test files written on project root folder

neo4j-contrib / spatial

Neo4j Spatial is a library of utilities for Neo4j that faciliates the enabling of spatial operations on data. In particular you can add spatial indexes to already located data, and perform spatial operations on the data like searching for data within specified regions or within a specified distance of a point of interest. In addition classes are provided to expose the data to geotools and thereby to geotools enabled applications like geoserver and uDig.

http://neo4j-contrib.github.io/spatial

Other

780 stars 192 forks source link

Unit test failures: billesholm.osm file is missing and test files written on project root folder #357

Open deniger opened 5 years ago

deniger commented 5 years ago

I'd like to propose a PR to migrate geotools from 14.4 to 21.0. See:

Before creating this PR, I launched unit tests and I have an issue with org.neo4j.gis.spatial.TestSpatial: java.io.FileNotFoundException: target\osm\billesholm.osm

I believe that the file billesholm.osm is missing. Where could I find it ?

Another points: it seems that some files generated by unit tests are stored in project root folder: ( I can try to modify this point and let unit test generate files in the target folder).

Last point: unit tests are not launched by travis. Should I modifiy travis to launch them ?

craigtaverner commented 5 years ago

I like all suggestions.

Messy tests that output stuff outside target should be cleaned up to output to target
It would be good if travis CI ran unit tests, then mistakes like the missing billesholm.osm would have been caught
Fantastic that you've done work to port to newer geotools, and I'm looking forward to the PR to review.

deniger commented 5 years ago

I ll push my PR on Monday ;). Could I ignore the test using the file billeshom or is there any chance to retrieve the file?

Then I could propose a new PR for unit test and Travis.

Happy to help :)

---- On Sat, 06 Apr 2019 12:35:59 +0200 notifications@github.com wrote ----

I like all suggestions.

Messy tests that output stuff outside target should be cleaned up to output to target It would be good if travis CI ran unit tests, then mistakes like the missing billesholm.osm would have been caught Fantastic that you've done work to port to newer geotools, and I'm looking forward to the PR to review.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

craigtaverner commented 5 years ago

Yes, ignore the test. I will find the file and unignore the test when I do.

craigtaverner commented 5 years ago

Also, for me to merge your PR's, please make sure to agree to the CLA, as described at https://neo4j.com/developer/cla/

deniger commented 5 years ago

done

---- On Sun, 07 Apr 2019 00:49:18 +0200 Craig Taverner notifications@github.com wrote ----

Also, for me to merge your PR's, please make sure to agree to the CLA, as described at https://neo4j.com/developer/cla/

— You are receiving this because you authored the thread. Reply to this email directly, https://github.com/neo4j-contrib/spatial/issues/357#issuecomment-480543751, or https://github.com/notifications/unsubscribe-auth/AtXaxamHJyQBs2NdIyKtd9BiKZuTQ2PHks5veSRugaJpZM4ce4Ge.