neo4j-documentation / asciidoctor-jupyter

A Jupyter converter for Asciidoctor.js. Write your Notebook in AsciiDoc!
16 stars 1 forks source link

add support for dlist #4

Closed prudhomm closed 1 year ago

prudhomm commented 2 years ago

dlist do not seem supported.

toto::
  titi
titi::
  toto

I get messages like

asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
prudhomm commented 2 years ago

since they are not supported by markdown, can we consider them as ulist and work with that ?

prudhomm commented 1 year ago

@ggrossetie we can certainly generate easily the markdown for a definition list, however I am not sure how to get the definition title and the definition body

ggrossetie commented 1 year ago

since they are not supported by markdown, can we consider them as ulist and work with that ?

I think we can take some inspiration from https://github.com/opendevise/downdoc which converts AsciiDoc to Markdown but I like your idea.

we can certainly generate easily the markdown for a definition list, however I am not sure how to get the definition title and the definition body

Usually, I take a look at how Asciidoctor (Ruby) converts an node to HTML: https://github.com/asciidoctor/asciidoctor/blob/cbd991a398cb10f28ce5c69c6ef0c6881c79fe39/lib/asciidoctor/converter/html5.rb#L516C25-L596

The interesting part: https://github.com/asciidoctor/asciidoctor/blob/cbd991a398cb10f28ce5c69c6ef0c6881c79fe39/lib/asciidoctor/converter/html5.rb#LL579-L591C24

ggrossetie commented 1 year ago

AsciiDoc

CPU:: The brain of the computer.
Hard drive:: Permanent storage for operating system and/or user files.
RAM:: Temporarily stores information the CPU uses during operation.
Keyboard:: Used to enter text or control items on the screen.
Mouse:: Used to point to and select items on your computer screen.
Monitor:: Displays information in visual form using text and graphics.

Markdown

* **CPU**\
The brain of the computer.
* **Hard drive**\
Permanent storage for operating system and/or user files.
* **RAM**\
Temporarily stores information the CPU uses during operation.
* **Keyboard**\
Used to enter text or control items on the screen.
* **Mouse**\
Used to point to and select items on your computer screen.
* **Monitor**\
Displays information in visual form using text and graphics.