search

neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Remove pipe from replaced characters in callouts #213

Closed nvitucci closed 8 months ago

nvitucci commented 8 months ago

The pipe is excluded from content when copied through the Copy icon, causing it to be skipped when a code block like in the Kafka docs is copied.

This PR seems to fix this behaviour, but I would like to understand what was the rationale for exclusion before applying it. This change was introduced in https://github.com/neo4j-documentation/docs-ui/pull/204, but from the discussion I can't understand why the pipe was excluded as well.

netlify[bot] commented 8 months ago

Deploy Preview for neo4j-docs-ui ready!

Name Link
Latest commit bee4ee1fb6fdc1b5bdb57f370d77750840ede827
Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/65cceed597d4d70009f415fa
Deploy Preview https://deploy-preview-213--neo4j-docs-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

recrwplay commented 8 months ago

The original intention was to strip lines by removing spaces from the end. Tabs where then also included and the regex for 'tabs or spaces' got a bit mangled.