neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Avoid autoscroll when changing tab in tabbed example. #226

Closed stefano-ottolenghi closed 5 months ago

stefano-ottolenghi commented 5 months ago

I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.

Before scroll

After no-scroll

Question for @adam-cowley and @recrwplay , if you remember from 4 years ago: why do we have both [.tabs] and [.tabbed-example]?

I believe we are actively only using [.tabbed-example]. If that's the case, can I declutter and entirely remove the [.tabs] bit?

netlify[bot] commented 5 months ago

Deploy Preview for neo4j-docs-ui ready!

Name Link
Latest commit 75557d5a2d9407c3d9289697ed53734eefb44ac0
Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/662f323b8cdf730008ba09c6
Deploy Preview https://deploy-preview-226--neo4j-docs-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

recrwplay commented 5 months ago

[.tabs] is not widely used, but I've found some examples in the APOC docs so we should not remove that.