search

neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Add tabbed sections in GDS documentation #35

Closed recrwplay closed 3 years ago

recrwplay commented 3 years ago

Adds the GDS modes to the list of 'langs' that can be tabbed.

Also, GDS prefer to display the tab even when there is only one tab, for example in Collapse Path. This PR displays the single tab if the 'lang' is a GDS mode.

ggrossetie commented 3 years ago

At some point, we should probably make the code more agnostic. It does not feel right to blend GDS modes in programming languages. Having said that, that would require larger changes so we can keep it that way until we need to add even more tabbed sections.

recrwplay commented 3 years ago

I agree it's not perfect, but for now it satisfies our needs until we can make those improvements.

ggrossetie commented 3 years ago

I agree it's not perfect, but for now it satisfies our needs until we can make those improvements.

:+1: I approved the pull request so this is good to go.

@adam-cowley do you want to review before merge?

adam-cowley commented 3 years ago

Yeah looks fine to me for now