search

neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Update global font weight to 400 #36

Closed spgandhi closed 3 years ago

spgandhi commented 3 years ago

This PR updates the body and nav font weight to 400. The var.css file has been updated for this.

The current font weight for body is 200 which is too light and not easily readable. It is also not web accessible and elderly people and people with any eye problems would find it difficult to read. We recently updated the font-weight to 400 of the main neo4j.com website for the same reasons. And we would like to do it for the docs section as well.

spgandhi commented 3 years ago

cc: @adam-cowley @Mogztter

ggrossetie commented 3 years ago

I'm fine with this change, I will let @adam-cowley merge.

recrwplay commented 3 years ago

Obviously I'm in favour of readability, but I'm concerned about the impact of this change on the overall appearance of the docs.

For example, paragraph text will get the same weight as headings, and the active item in the toc will have the same weight as the other entries.

I think we will need to also update the fonts included in the html head - anything font-style:italic, for example the abstract / description at the top of docs pages, is not currently affected by this change

recrwplay commented 3 years ago

FAO @davidoliverSP2

davidoliverSP2 commented 3 years ago

FAO @davidoliverSP2

Thanks @recrwplay & @spgandhi - please do not merge this PR until we've been able to fully review the impact on all documentation projects.

@adam-cowley are you the right person to review the Labs & Dev Guide output?

adam-cowley commented 3 years ago

It looks fine to me on labs and developer guides, could probably do with making the main text colour a little softer - --colour-grey-700?

spgandhi commented 3 years ago

@adam-cowley I do not have write access to the repo, so you will have to merge it please.