neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Improve runnable code blocks for GraphGists #58

Closed ggrossetie closed 3 years ago

ggrossetie commented 3 years ago
ggrossetie commented 3 years ago

Here's the result:

zoom-ok

adam-cowley commented 3 years ago

Nice, this looks a lot better. I'm spotting scrollbars on the graph view - I'm guessing there's an overview: scroll rather than overview:auto in there somewhere? Apart from that I'd say it's good to merge.

ggrossetie commented 3 years ago

Nice, this looks a lot better. I'm spotting scrollbars on the graph view - I'm guessing there's an overview: scroll rather than overview:auto in there somewhere? Apart from that I'd say it's good to merge.

Done 👍🏻

good

I've noticed that when we close result panes (or when we show query results) the "Feedback" position was not updated (despite the fact that footer has moved). I've added an intersection observer to update the "Feedback" position when the footer is visible in the viewport or not: https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API