neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

resolves #79 configure the connection URL when opening in Neo4j Browser #80

Closed ggrossetie closed 2 years ago

ggrossetie commented 2 years ago

image

Please note that the Neo4j browser URL must be updated in: https://github.com/neo4j-documentation/developer-site-generator/blob/6ed0f86dd124b86d7fbbe4fabe36784e0ad2d6be/lib/graphgists.js#L281

resolves #79

netlify[bot] commented 2 years ago

✔️ Deploy Preview for neo4j-docs-ui ready!

🔨 Explore the source changes: 198059d0b6ac38d90916b57b42d450b524e4f07e

🔍 Inspect the deploy log: https://app.netlify.com/sites/neo4j-docs-ui/deploys/61814f11dd583400086ccfe0

😎 Browse the preview: https://deploy-preview-80--neo4j-docs-ui.netlify.app

adam-cowley commented 2 years ago

This looks good, exactly what I was thinking for the input box and button.

I think that a fieldset can only be used within a form so might be worth a double-check. Could you remove the border on it if it is kept? Everything looks a bit squashed too if you could add some padding? Otherwise, looks good to go!

ggrossetie commented 2 years ago

I think that a fieldset can only be used within a form so might be worth a double-check.

I did check and apparently it can be used in any element that accepts flow content.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Fieldset#technical_summary

Could you remove the border on it if it is kept? Everything looks a bit squashed too if you could add some padding? Otherwise, looks good to go!

Sure 👍🏻

Please note that we should upgrade both the UI and the site generator at the same time (because this feature relies on https://github.com/neo4j-documentation/developer-site-generator/commit/51f22aa75a2d3ffa92275bb19643e888776ee149).

ggrossetie commented 2 years ago

Is it better?

image

adam-cowley commented 2 years ago

LGTM 🔥