search

neo4j-documentation / docs-ui

Mozilla Public License 2.0
4 stars 23 forks source link

Fix removed css vars #86

Closed recrwplay closed 2 years ago

recrwplay commented 2 years ago

Updates labels.css for the new classes added in #85

Also adds vertical spacing to labels in .tableblock for when labels don't fit in the horizontal space.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for neo4j-docs-ui ready!

🔨 Explore the source changes: 86685d4900956bedfce80cded33972b59660fde6

🔍 Inspect the deploy log: https://app.netlify.com/sites/neo4j-docs-ui/deploys/61f2859f63355b0008e80c02

😎 Browse the preview: https://deploy-preview-86--neo4j-docs-ui.netlify.app

adam-cowley commented 2 years ago

I think the naming convention here is to signify that it came from the neo4j design system - long term we should move away from color-* to a relevant colour in the design system to make it feel more uniform. So from this point of view I'd be happy to keep this as it is and phase out color-* unless you have any objections.

Any thoughts @spgandhi?

spgandhi commented 2 years ago

I would perhaps not have an opinion on it at this point in time.

Looking at naming convention in the Design System right now, we have --colors-primary-40 for examlpe.

Screenshot 2022-02-02 at 10 41 35 AM
recrwplay commented 2 years ago

In the meantime, docs pages currently have labels that are not appearing. Can this be merged, and if not, what can I do to make it mergeable?