search

neo4j-examples / movies-kotlin-spring-data-neo4j

Neo4j Movies Example with Kotlin, Spring Boot & Spring Data Neo4j
Apache License 2.0
25 stars 12 forks source link

Split project into persistence and security #3

Open asarkar opened 6 years ago

asarkar commented 6 years ago

I'm learning Spring Data Neo4J and this is probably the only application that is written in Kotlin, so thanks for that. However, as a beginner to Spring Data Neo4J but not to other areas of Spring, I'm finding the mixing of 2 separate areas of concern somewhat hindering my understanding of the code. I suggest that security be made orthogonal, and optional, to the actual code, which is persisting a graph in Neo4J. This can be done by simply splitting the project into 2 modules, one for persistence, and another for security. Security would be enabled by default but could be turned off by activating a profile at runtime.

Also, FYI, Kotlin coding conventions require omitting the common base package directories, thus giving some relief to the deep packages that are so common in Java projects.

jasperblues commented 6 years ago

Hey @asarkar thanks for the suggestions. Would you like to send a pull request for either of those?

asarkar commented 6 years ago

Like I said, I'm still learning, but if you keep the ticket open, I can try.

jasperblues commented 6 years ago

You are very welcome to try if you like. Will be happy to review.