search

neo4j-graphql / neo4j-graphql-java

Neo4j Labs Project: Pure JVM translation for GraphQL queries and mutations to Neo4j's Cypher
Apache License 2.0
105 stars 49 forks source link

updated logic for endNodePattern to include label information in the variable name #296

Closed ghost closed 1 year ago

ghost commented 1 year ago

updated logic for endNodePattern to include label information in the variable name.

It fixes #295

Andy2003 commented 1 year ago

Can you add a test that coveres the bug (with the wrong where-parameters)

ghost commented 1 year ago

Added a test case to validate variable name in where condition.

ghost commented 1 year ago

Hi @Andy2003 I have added a test case to validate variable name in where condition. Can you please review it? Thanks

ghost commented 1 year ago

Hi. I will add it today. I got held up with some other work.

ghost commented 1 year ago

Do you want to add integration test assertions?

You are talking about adding this response in my test, right?

.GraphQL-Response
[source,json,response=true,ignore-order]
----
{
 "expected": "graphql response"
}
----
Andy2003 commented 1 year ago

Please fix the tests!

ghost commented 1 year ago

Please fix the tests!

In my local, all the CypherTests are running fine.

picc

After running mvn clean install, I don't see any test failure in Neo4j GraphQL Java 1.7.1-SNAPSHOT

image

Andy2003 commented 1 year ago

Why did you close this PR? The reason the test ware failing here is, that the integration are also ran. These tests are disabled by default, so your mvn clean install does not run these tests.

Andy2003 commented 1 year ago

I will take a look at this