search

neo4j-graphql / neo4j-graphql-js

NOTE: This project is no longer actively maintained. Please consider using the official Neo4j GraphQL Library (linked in README).
Other
609 stars 147 forks source link

inferSchema should use explicit transaction functions #459

Open johnymontana opened 4 years ago

johnymontana commented 4 years ago

To ensure client retries and refresh of the Neo4j cluster routing table, explicit driver transaction functions should be used by inferSchema.

Transaction functions are used by neo4jgraphql when sending queries in most cases, however inferSchema is still using the implicit session.run functions. Change these to use explicit transaction functions:

https://github.com/neo4j-graphql/neo4j-graphql-js/blob/19b576ffef6a09f435389d096c59c8f387b586c7/src/neo4j-schema/Neo4jSchemaTree.js#L48-L102

michaeldgraham commented 3 years ago

https://github.com/neo4j-graphql/neo4j-graphql-js/issues/608