Parameter Select not searching after upgrade from 2.2.5 to 2.3.1

neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j

https://neo4j.com/labs/neodash/

Apache License 2.0

420 stars 141 forks source link

Parameter Select not searching after upgrade from 2.2.5 to 2.3.1 #563

Closed luzidl closed 1 year ago

luzidl commented 1 year ago

After upgrading a couple of Dashboards from 2.2.5 to 2.3.1 parameter select seems to not take input that is stored as number in the database. Cut and paste of an accountID (data type: number, eg. 55716) provided a result in NeoDash 2.2.5, but did not find it in 2.3.1. Searching by typing the same account ID number does not work either. (See graphics attached below):

NeoDash version: 2.2.5 --> 2.3.1
Neo4j Database version: 4.4. 3 (Enterprise).
Steps to reproduce
Migrate a DB (4.4.3) from NeoDash 2.2.5 to 2.3.1 using a parameter select visualization on a node property that is a data type number and try to search a number in both.
Expected: Number is found immediately if pasted or partially if it it typed.

NeoDash 2.2.5:

NeoDash 2.3.1:

BennuFire commented 1 year ago

Hi @luzidl ,

This should be already fixed on the version 2.3.2 that we are expecting to release today 😀

BennuFire commented 1 year ago

You get a preview of it on http://neodash-test.graphapp.io.s3-website-us-west-1.amazonaws.com/

luzidl commented 1 year ago

Cool, thanks for the feedback! I did not see any open bug, thus I opened it. Looking forward to the fix.

BennuFire commented 1 year ago

I just released 2.3.2. Can you confirm this is solved for you now?

luzidl commented 1 year ago

Nope, it is still not working. Same as before, no results found when pasting a number or typing a number.

luzidl commented 1 year ago

@BennuFire any thoughts when this will be fixed? :-) It is an essential functionality in my AML&Fraud Demo. Thx in advaned!

gcthys commented 1 year ago

Hi @luzidl,

This bug worried me, so I tried to replicatie it on my dashboard. I took a random property of a random node with type "integer" and it seems to work fine:

Are you sure you didn't inadvertently change something in the settings? (just trying to think along...)

Guido

BennuFire commented 1 year ago

@luzidl I'm still trying to replicate the issue with no success. Can you share you dashboard json?

luzidl commented 1 year ago

For sure @BennuFire, will send it via email in a moment.

BennuFire commented 1 year ago

Fixed on 2.3.5

luzidl commented 1 year ago

@BennuFire, not entirely as I can see. I can not find the accountIds, but the queries are not finding anything. It seems, that parameter is not set correctly. I also tried to convert it explicitly to a number format and to a String format, but nothing works. Queries do not return any data. See screenshot below:

BennuFire commented 1 year ago

You are completely right @luzidl , I fixed the dropdown display but missed the propagation. It's fixed here https://github.com/neo4j-labs/neodash/pull/641 . I think we will do another release later this week.