Closed nielsdejong closed 8 months ago
I think the uuid also needs to be changed if there is a new dashboard name. Otherwise I have encountered an issue with 2.4.1 where the draft will overwrite the existing saved dashboard. The way I found around this was to export the prev version json, clone the prev dashboard node and manually modify the uuid, then save current draft so that the current version I am working on does not overwrite the previous version.
Attention: 398 lines
in your changes are missing coverage. Please review.
Comparison is base (
20e4e0a
) 39.07% compared to head (f4f8181
) 38.83%. Report is 71 commits behind head on develop.:exclamation: Current head f4f8181 differs from pull request most recent head 03d196c. Consider uploading reports for the commit 03d196c to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
In the previous version of the sidebar, the currently edited dashboard (the 'draft') was always located at
index = -1
of the list (i.e. the very first element to be displayed before all currently saved dashboards).This PR changes this. Now, the sidebar lets people edit existing dashboards (remembering their current index), and provide the draft interface for the currently selected dashboard, without using the explicit "index = -1" entry.
The explicit entry does still exist though, as when a person has created a dashboard that is not yet saved to the database, there is no matching element in the list. Here, we do use the "-1" entry.