neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
408 stars 135 forks source link

Adding in 3D graph visualization as an advanced visualization #737

Closed nielsdejong closed 8 months ago

nielsdejong commented 8 months ago

Added an implementation & docs for a 3D graph renderer in src/extensions/advancedcharts/chart/graph3d/.

This new visualization inherits 95% of the properties from the 2D graph visualization, I did some refactoring to the original report's base class to enable re-use.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 362 lines in your changes are missing coverage. Please review.

Comparison is base (20e4e0a) 39.07% compared to head (4077488) 38.89%. Report is 70 commits behind head on develop.

Files Patch % Lines
src/dashboard/DashboardThunks.ts 3.57% 81 Missing :warning:
...charts/chart/graph3d/GraphChartVisualization3D.tsx 2.63% 37 Missing :warning:
src/chart/graph/GraphChartVisualizationBase.tsx 34.61% 34 Missing :warning:
src/application/logging/LoggingThunk.ts 2.94% 33 Missing :warning:
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 30 Missing :warning:
src/chart/bar/util.ts 0.00% 26 Missing :warning:
src/chart/bar/BarChart.tsx 75.55% 22 Missing :warning:
src/dashboard/header/DashboardHeaderPageTitle.tsx 19.04% 17 Missing :warning:
src/dashboard/header/DashboardTitle.tsx 31.81% 14 Missing and 1 partial :warning:
src/dashboard/sidebar/DashboardSidebar.tsx 13.33% 12 Missing and 1 partial :warning:
... and 18 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #737 +/- ## =========================================== - Coverage 39.07% 38.89% -0.19% =========================================== Files 208 211 +3 Lines 8721 8796 +75 Branches 2598 2614 +16 =========================================== + Hits 3408 3421 +13 - Misses 5252 5314 +62 Partials 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

29.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud