neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
408 stars 135 forks source link

fixing rule based styling wrong casting at number #738

Closed alfredorubin96 closed 8 months ago

alfredorubin96 commented 8 months ago

There was a double casting at number in the code preventing the correct application of the rule

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 8 months ago

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (4e2c2f4) 38.69% compared to head (52426c8) 39.04%. Report is 46 commits behind head on develop.

Files Patch % Lines
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 29 Missing :warning:
src/chart/bar/util.ts 0.00% 26 Missing :warning:
src/chart/bar/BarChart.tsx 75.28% 22 Missing :warning:
...ns/text2cypher/component/QueryTranslatorButton.tsx 0.00% 5 Missing :warning:
src/dashboard/DashboardThunks.ts 0.00% 4 Missing :warning:
src/extensions/advancedcharts/Utils.ts 33.33% 2 Missing :warning:
.../text2cypher/component/OverrideCardQueryEditor.tsx 0.00% 1 Missing :warning:
src/modal/ExportModal.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #738 +/- ## =========================================== + Coverage 38.69% 39.04% +0.35% =========================================== Files 207 208 +1 Lines 8630 8718 +88 Branches 2567 2597 +30 =========================================== + Hits 3339 3404 +65 - Misses 5231 5252 +21 - Partials 60 62 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.