search

neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
408 stars 135 forks source link

Fix Iframe wrong component injection #741

Closed alfredorubin96 closed 8 months ago

alfredorubin96 commented 8 months ago

If passing down a parameter as input to the iframe, the component wasn't working because the function was returning a component instead of a string. The replace function can now return a string or a set of components, it will depend on the value called render (defaulted to true)

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

codecov[bot] commented 8 months ago

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (4e2c2f4) 38.69% compared to head (9a5987e) 39.04%. Report is 48 commits behind head on develop.

Files Patch % Lines
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 29 Missing :warning:
src/chart/bar/util.ts 0.00% 26 Missing :warning:
src/chart/bar/BarChart.tsx 75.28% 22 Missing :warning:
...ns/text2cypher/component/QueryTranslatorButton.tsx 0.00% 5 Missing :warning:
src/dashboard/DashboardThunks.ts 0.00% 4 Missing :warning:
src/chart/ChartUtils.ts 33.33% 2 Missing :warning:
src/extensions/advancedcharts/Utils.ts 33.33% 2 Missing :warning:
.../text2cypher/component/OverrideCardQueryEditor.tsx 0.00% 1 Missing :warning:
src/modal/ExportModal.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #741 +/- ## =========================================== + Coverage 38.69% 39.04% +0.35% =========================================== Files 207 208 +1 Lines 8630 8718 +88 Branches 2567 2599 +32 =========================================== + Hits 3339 3404 +65 - Misses 5231 5252 +21 - Partials 60 62 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nielsdejong commented 8 months ago

I did an alternative fix for this one in https://github.com/neo4j-labs/neodash/pull/744. (Sorry, missed this!)

Hope you don't mind I close this one :)