neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
418 stars 138 forks source link

Feature/customer n dashboard rbac label #755

Closed AleSim94 closed 8 months ago

AleSim94 commented 9 months ago

This feature is about providing a way for users with at least write permissions or higher to use Access control from the UI. In order to do that, Navigate to the sidebar and enter the dashboard settings of a dashboard of your choice and select the 'Access Control' Button. Inside you should be able to get a list of all the current labels attached to the current dashboard. What you could do is add either more labels that already exist in the db to this dashboard node or create a completely new label and attach it to this dashboard node. The new label will only be persisted in the db if you save the changes.

what has been added is a new component called 'NeoDashboardSidebarAccessModal' to the export NeoDashboardSidebar. Documentation has also been added to this feature explaining how it works.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 510 lines in your changes are missing coverage. Please review.

Comparison is base (20e4e0a) 39.07% compared to head (a7e45dd) 38.64%. Report is 79 commits behind head on develop.

Files Patch % Lines
src/dashboard/DashboardThunks.ts 3.57% 81 Missing :warning:
src/dashboard/sidebar/DashboardSidebar.tsx 12.06% 50 Missing and 1 partial :warning:
...oard/sidebar/modal/DashboardSidebarAccessModal.tsx 34.72% 47 Missing :warning:
...charts/chart/graph3d/GraphChartVisualization3D.tsx 2.63% 37 Missing :warning:
src/chart/graph/GraphChartVisualizationBase.tsx 34.61% 34 Missing :warning:
src/application/logging/LoggingThunk.ts 2.94% 33 Missing :warning:
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 33 Missing :warning:
src/chart/bar/util.ts 0.00% 26 Missing :warning:
src/chart/bar/BarChart.tsx 75.55% 22 Missing :warning:
src/dashboard/header/DashboardHeaderPageTitle.tsx 19.04% 17 Missing :warning:
... and 29 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #755 +/- ## =========================================== - Coverage 39.07% 38.64% -0.44% =========================================== Files 208 214 +6 Lines 8721 8951 +230 Branches 2598 2650 +52 =========================================== + Hits 3408 3459 +51 - Misses 5252 5431 +179 Partials 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud