neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
400 stars 129 forks source link

Fixing wrong behaviour in GraphChart report Action #782

Closed alfredorubin96 closed 5 months ago

alfredorubin96 commented 5 months ago

Drafting solution, looks like is deeper than expected in the graphChart Still missing:

  1. can't apply rule to links
  2. to understand why the code is breaking from the graphChart (ruleValues arrive in the form (label.rValue)
codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (20e4e0a) 39.07% compared to head (48c0adc) 38.81%. Report is 89 commits behind head on develop.

:exclamation: Current head 48c0adc differs from pull request most recent head d56cccd. Consider uploading reports for the commit d56cccd to get more accurate results

Files Patch % Lines
...rc/extensions/actions/ActionsRuleCreationModal.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #782 +/- ## =========================================== - Coverage 39.07% 38.81% -0.27% =========================================== Files 208 211 +3 Lines 8721 8837 +116 Branches 2598 2637 +39 =========================================== + Hits 3408 3430 +22 - Misses 5252 5346 +94 Partials 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nielsdejong commented 5 months ago

Lets create a seperate issue for the other tasks, it definitely is much bigger! Will merge this for 2.4.3

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud