search

neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
400 stars 129 forks source link

Fix/parameter select #794

Closed alfredorubin96 closed 5 months ago

alfredorubin96 commented 5 months ago

FIxing:

  1. When initialising the selector in multi mode, it was pushing also an empty string in the list of values
  2. when clearing the list, the values weren't casted to string
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 38.55%. Comparing base (20e4e0a) to head (9dcb8a2). Report is 94 commits behind head on develop.

Files Patch % Lines
...arameter/component/NodePropertyParameterSelect.tsx 37.50% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #794 +/- ## =========================================== - Coverage 39.07% 38.55% -0.53% =========================================== Files 208 211 +3 Lines 8721 8858 +137 Branches 2598 2644 +46 =========================================== + Hits 3408 3415 +7 - Misses 5252 5385 +133 + Partials 61 58 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.