Open m-o-n-i-s-h opened 7 months ago
Failed conditions
7.3% Duplication on New Code (required ≤ 3%)
Attention: Patch coverage is 11.76471%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 39.49%. Comparing base (
d165cce
) to head (0432950
). Report is 32 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
src/utils/parameterUtils.ts | 18.18% | 9 Missing :warning: |
src/extensions/forms/chart/NeoForm.tsx | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you please check the code duplication and if you can add testing for this new behaviour in Cypress? Thank you so much for contributing to the project!
Failed conditions
7.1% Duplication on New Code (required ≤ 3%)
Disable forms button until all the necessary parameters are provided.
Description
This pull request introduces a modification to the forms functionality, specifically targeting the submit button. The primary change ensures that the submit button remains disabled until all the necessary parameters are provided by the user. This enhancement is essential for improving the user experience and preventing incomplete form submissions.
Changes Made
Screenshots
Actual Behaviour:
New Behaviour:
NOTICE
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish monish.nandakumaran@mercedes-benz.com on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md
Sample JSON:
movieDisableFormButton.json
Signed off: Monish monish.nandakumaran@mercedes-benz.com