neo4j-labs / neodash

NeoDash - a Dashboard Builder for Neo4j
https://neo4j.com/labs/neodash/
Apache License 2.0
394 stars 127 forks source link

[Feature #884] Helm chart for Kubernetes deployments #902

Open venkatalolla opened 1 month ago

venkatalolla commented 1 month ago

PR Description

This is a new feature request to create a Helm chart to support the Kubernetes based deployments in a package pattern. This Helm chart should enable the NeoDash deployment in either editor or reader mode for easy versioning, packaging and installing these dashboards at an enterprise level.

The solution includes a Helm chart with the following Kubernetes resources templates to support the editor or reader mode for ease of deployment,

As an alternative solution I also included the required Kubernetes YAML files to deploy the NeoDash with Kubectl commands.

884

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

alfredorubin96 commented 3 weeks ago

Hi @venkatalolla, thank you for your contribution! Could you please check the warning that are popping up in this page and check whether they are critical or not?

Thanks again for helping the project!

venkatalolla commented 3 weeks ago

Hey @alfredorubin96, thanks a bunch for taking the time to review my pull request! 😄 If you're referring to the SonarCloud warnings, I've already taken care of them in my most recent commit, and they're all gone now. Just wanted to let you know, and also, they weren't critical anyway.

alfredorubin96 commented 2 weeks ago

Looked at the code and sounds good to me, could you please provide me an easy way to test it? I'm not an expert in developing helm charts, but there is a way in which we can test the deployment inside our pipelines?

venkatalolla commented 2 weeks ago

Hello @alfredorubin96, Thank you for the response. For testing the Helm chart deployment, I have put together a GitHub workflow in my own repository, https://github.com/venkatalolla/neodash-kind-helm-workflow, that deploys the Helm chart to a local KinD Kubernetes cluster and validates the 200 response for the NeoDash URL using CURL.

For your information, I have tested the above-shared workflow here using the same code from this PR as an example.

Let me know if you want me to provide more details on the GitHub workflow or the deployment.

venkatalolla commented 2 weeks ago

@alfredorubin96, please let me know if you need more information on my last comment.