search

neo4j-php / neo4j-php-client

Php client and driver for neo4j database
https://neo4j.com/developer/php/
MIT License
160 stars 40 forks source link

update psr/http-message ^2.0 & add ext-mbstring & update stefanak-michal/bolt ^5.1 -> ^6.0 #196

Closed lcp0578 closed 6 months ago

lcp0578 commented 7 months ago

update psr/http-message ^2.0

lcp0578 commented 7 months ago

When I use it for symfony 6.4 it need psr/http-message ^2.0

transistive commented 7 months ago

Thank you for the update! I'll be running some test and merge it later today. Good job!

lcp0578 commented 7 months ago

I'm not sureneed to add constraints,

"ext-mbstring": "*"

although Blot already has constraints, https://github.com/neo4j-php/Bolt/blob/master/composer.json#L12 but when I require this libraries, composer didn't tell me that I needed mbstring extensions, which really wasted a lot of my time, and I found out through debugging that I really didn't have it, but it's not so intuitive, and I hope it will reduce the time of other people who use this library.

lcp0578 commented 7 months ago

I think "php": "^8.0", https://github.com/neo4j-php/neo4j-php-client/blob/main/composer.json#L24 so,
image

https://github.com/neo4j-php/Bolt/releases/tag/v6.0.0

I'd like PHP's version constraints to be consistent.

stefanak-michal commented 7 months ago

If you are updating more than psr/http-message you should update PR name.

lcp0578 commented 7 months ago

If you are updating more than psr/http-message you should update PR name.

I update the PR name, thx.

lcp0578 commented 7 months ago

@transistive If you have time to deal with this PR, my team and I urgently need to update a version.