search

neo4j / apoc

Apache License 2.0
84 stars 27 forks source link

[yaWCMgIP] Exclude asm to fix startup issue #561

Closed gem-neo4j closed 8 months ago

gem-neo4j commented 8 months ago

I tested this manually by copying the jar to desktop and changing the name to: apoc5plus-5.15.0, without this change it fails, with it works (also with it, there is no trace of it in the logs either)

gem-neo4j commented 8 months ago

I think so, what I did was I checked the dependencies in APOC, and it was listed under org.neo4j:neo4j-codegen:5.16.0-SNAPSHOT, org.neo4j:test-utils:5.16.0-SNAPSHOT as well, and the POM in codegen for example was:

                <configuration>
                    <artifactSet>
                        <includes>
                            <include>org.ow2.asm:*</include>
                        </includes>
                    </artifactSet>
                    <relocations>
                        <relocation>
                            <pattern>org.objectweb.asm</pattern>
                            <shadedPattern>org.neo4j.codegen.asm</shadedPattern>
                        </relocation>
                    </relocations>
                    <createDependencyReducedPom>false</createDependencyReducedPom>
                </configuration>

I assumed include here implies it is shipped with Neo. Is there another way I can check?

gem-neo4j commented 8 months ago

/generateLicenses

neo-technology-build-agent commented 8 months ago

:x: generateLicenses failed

ncordon commented 8 months ago

/generateLicenses

ncordon commented 8 months ago

test-utils is not a good example because I assume it's only used with testing scope, so it's not included in neo4j's jar:

For example:

[INFO] org.neo4j:neo4j-values:jar:5.17.0-SNAPSHOT
[INFO] \- org.neo4j:test-utils:jar:5.17.0-SNAPSHOT:test
[INFO]    \- org.ow2.asm:asm:jar:9.6:test

About the codegen one you are right, it's included in the procedure framework:

[INFO] org.neo4j:neo4j-procedure:jar:5.17.0-SNAPSHOT
[INFO] \- org.neo4j:neo4j-codegen:jar:5.17.0-SNAPSHOT:compile
[INFO]    \- org.ow2.asm:asm:jar:9.6:compile

By the way, I got this from the monorepo doing mvn dependency:tree -Dincludes=org.ow2.asm:asm