neo4j / graph-data-science-client

A Python client for the Neo4j Graph Data Science (GDS) library
https://neo4j.com/product/graph-data-science/
Apache License 2.0
183 stars 44 forks source link

Support relationship type as str in `gds.graph.relationshipProperties.stream` #658

Closed orazve closed 2 months ago

orazve commented 2 months ago

The problem from issue #554 was reproduced locally and showed that gds.graph.relationshipProperties.stream has different API in Cypher and Python Client sides: Cypher can get list[str] as relationshipType, but Python Client can get str and list[str].

This PR contain:

Question: why this problem is not reproduced by CI, where we run kge-predict-transe-pyg-train.ipynb which calls gds.graph.relationshipProperties.stream function with relationshipType as str, not with list[str]?

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

netlify[bot] commented 2 months ago

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
Latest commit f1cd3eb2682d6d24a696753a816f7c65745215cd
Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/66719b6353511b00083ecaa0
brs96 commented 2 months ago

and changelog entries, I think it's two separate bug fixes?