Closed frank-zsy closed 2 years ago
@s1ck could you have a look on this pull please?
@frank-zsy Thanks for the PR. I was afk last week and didn't see it until now! Will have a look.
Thanks, should I add the Logging
section to 2.4
just before Message reducer
or 2.6
?
Thanks, should I add the
Logging
section to2.4
just beforeMessage reducer
or2.6
?
Let's do 2.6 Logging
and briefly describe that the "following methods" are available at the three context objects and that they allow us to inject custom messages into the progress log of the algorithm execution.
Thanks for the review, I looked into the documentation carefully and found almost equal number of function
and method
, is there any convention when to use which?
Thanks for the review, I looked into the documentation carefully and found almost equal number of
function
andmethod
, is there any convention when to use which?
It's true that it's mixed up, but since we use Java code snippets here, using method
seems appropriate.
Sure, thanks.
Signed-off-by: Frankzhaopku syzhao1988@126.com
Before submitting this PR, please make sure:
This PR tends to add a build-in logger to Pregel framework. close #180
I looked into the code and
InitContext
andComputeContext
derive fromNodeCentricContext
which derives fromPregelContext
. AndMasterComputeContext
derives fromPregelContext
, so I add a privateProgressTracker
reference into thePregelContext
and expose three public functionslogDebug
,logWarning
andlogMessage
which will call the same functions in the tracker, so developers can use them in all three contexts in the framework.What I am not sure is: