search

neo4j / graph-data-science

Source code for the Neo4j Graph Data Science library of graph algorithms.
https://neo4j.com/docs/graph-data-science/current/
Other
621 stars 160 forks source link

Fixed windows tests failing due to CR;LF issues #196

Closed yuvalr1 closed 2 years ago

yuvalr1 commented 2 years ago

Some tests were failing on Windows due to differences in CR;LF with Unix. Replacing the hardcoded '\n' in these tests with a call to System.lineSeparator() which returns '\n' on Unix and '\r\n' on Windows fixed the problem.

Partially fixes #195 (fixes the trivial CRLF issues)

yuvalr1 commented 2 years ago

I only ran the tests on Windows, but I'm counting on the Github workflow to run the tests on Unix as well. Please tell me if this is not the case, and I will run the tests on a Unix machine.

Mats-SX commented 2 years ago

This repository is a public mirror of the repository which we really work on. I have ported this PR to the internal repo, and will merge it from there. It should show up in this repo tomorrow.

Thanks for your contribution!

yuvalr1 commented 2 years ago

@Mats-SX Thank you for merging the fix and for your additional improvements and comments. There were a few other tests mentioned in #195 that this PR doesn't solve because they were less trivial. I will try to find some time getting to them as well.