search

neo4j / graph-data-science

Source code for the Neo4j Graph Data Science library of graph algorithms.
https://neo4j.com/docs/graph-data-science/current/
Other
639 stars 161 forks source link

OpenGDS JAR as release asset #275

Open JohT opened 1 year ago

JohT commented 1 year ago

It would be great to get the OpenGDS JAR as release asset additionally to the existing one.

The steps to do that are already described in the main documentation under Building the library/Packaging the library. This could be done with GitHub Actions in an automated manner. Of course, this would need to fit/join the current release process (that I'm not aware of).

Alternatives

An alternative would be to create an own non official repository that clones this repository, creates the bundle and then releases it.

Additional context

I'm open to contribute GitHub Action(s) if this is of any help.

PS.: Thanks 👏 for this awesome library.

FlorentinD commented 1 year ago

Hello @JohT , thanks for your request. Could you explain why you want to use the OpenGDS jar?

JohT commented 1 year ago

Hi @FlorentinD,

thanks for your response. The main README.md states in section opengds that:

The Neo4j Graph Data Science library as built and distributed by Neo4j includes the sources in this repository as well a suite of closed sources. Neo4j GDS is available to download and use under the constraints of its license.

This makes me unsure if it is a good idea to just use the release artifacts provided. I'm not a lawyer so i assume, that the open version is a better fit for open projects like mine: https://github.com/JohT/code-graph-analysis-pipeline

Mats-SX commented 1 year ago

Disregard my previous reply, it contained inaccuracies (so I deleted it).

JohT commented 1 year ago

No worries. I found it insightful and am now curious about the inaccuracies.😀

I forgot to mention that I've created the following repository that automates the Open Graph Data Science build, packaging and release: https://github.com/JohT/open-graph-data-science-packaging

It is only a temporary solution and I might be removed in future.

Mats-SX commented 1 year ago

Well, I was mistaken on the license we ship with Neo4j GDS. It does indeed not fit for your purpose, so your request (and solution) is valid.