search

neo4j / graph-data-science

Source code for the Neo4j Graph Data Science library of graph algorithms.
https://neo4j.com/docs/graph-data-science/current/
Other
596 stars 157 forks source link

fixed compat matrix table headers #298

Closed ikwattro closed 2 months ago

ikwattro commented 4 months ago

The compatibility matrix table headers are mixed up, this MR fixes it.

Screenshot 2024-02-05 at 20 38 19
Mats-SX commented 4 months ago

Woopsie. Thanks for this contribution! I have verified your CLA signature and will apply your commit to our source repo. Expect results to show up soon.

Mats-SX commented 4 months ago

Actually, I think something else is wrong here. Your fix is certainly valid, but I think the intention is to have the Java version as the right-most column. So I will make a slightly different change on top where the headers are preserved, but the columns move so as to make it consistent.

I had to go back a fair bit in history to find this table in correct form. For some reason, constructing these tables with multi-cell spanning is tricky for many of us!

https://github.com/neo4j/graph-data-science/blob/2.3/README.adoc

ikwattro commented 4 months ago

@Mats-SX Sure, also no special need to keep my commit. The most important is that you were aware of the issue and that the readers will see a correct header.

Cheers