neo4j / graph-data-science

Source code for the Neo4j Graph Data Science library of graph algorithms.
https://neo4j.com/docs/graph-data-science/current/
Other
596 stars 157 forks source link

GraphDataScience constructor version check failed on 'neo4j' database #300

Closed Mintactus closed 3 months ago

Mintactus commented 3 months ago

When using the GDS python client

The GDS GraphDataScience constructor is complaining about not finding the database 'neo4j' It seems there is a version check gds.version() when trying to create a gds object, this check is ignoring the database parameter of the constructor and make everything crash.

The database I'm trying to connect to is provided and it's not the neo4j database. But even if it's not provided, the default database to check the version of GDS should always be system, not neo4j, who will mostly not exists in many production environments.

GraphDataScience(neo4j_credentials['uri'], auth=neo4j_credentials['auth'], database=neo4j_credentials['database'])

Mats-SX commented 3 months ago

Hi @Mintactus and thanks for raising this issue. This seems like an obvious bug that we should fix.

adamnsch commented 3 months ago

We created a fix for this issue now: https://github.com/neo4j/graph-data-science-client/pull/607 It will hopefully be merged soon

Mintactus commented 3 months ago

Excellent, thank you

On Fri, Mar 15, 2024, 5:27 a.m. Adam Schill Collberg < @.***> wrote:

We created a fix for this issue now: neo4j/graph-data-science-client#607 https://github.com/neo4j/graph-data-science-client/pull/607 It will hopefully be merged soon

— Reply to this email directly, view it on GitHub https://github.com/neo4j/graph-data-science/issues/300#issuecomment-1999256693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHIBVDN6H2OVV6QQGHISRDLYYK5GTAVCNFSM6AAAAABEWZO63SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGI2TMNRZGM . You are receiving this because you were mentioned.Message ID: @.***>

adamnsch commented 3 months ago

The PR is merged now, and it will be included in the next release of graphdatascience, so closing this now. Thanks again @Mintactus for reporting this