neo4j / graphql

A GraphQL to Cypher query execution layer for Neo4j and JavaScript GraphQL implementations.
https://neo4j.com/docs/graphql-manual/current/
Apache License 2.0
504 stars 149 forks source link

Fix #5467 #5470

Closed angrykoala closed 2 months ago

angrykoala commented 2 months ago

Description

Fix problem with parameters colliding in the cypher directive

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: a35b9ba232e78742758b8c7f0937134f6cdd938a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------ | ----- | | @neo4j/graphql | Patch | | @neo4j/graphql-ogm | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

neo4j-team-graphql commented 2 months ago

Performance Report

No Performance Changes

Show Full Table | name | dbHits | old dbHits | time (ms) | old time (ms) | maxRows | | ---- | ------ | ---------- | --------- | ------------- | ------- | | aggregations.TopLevelAggregate | 3404 | 3404 | 38 | 43 | 1134 | | aggregations.TopLevelAggregateWithMultipleFields | 6802 | 6802 | 50 | 72 | 1134 | | aggregations.NestedAggregation | 15407 | 15407 | 61 | 102 | 2174 | | aggregations.AggregationWithWhere | 10833 | 10833 | 44 | 62 | 2174 | | aggregations.AggregationWhereWithinNestedRelationships | 20097917 | 20097917 | 2286 | 2436 | 2008534 | | aggregations.AggregationWhereWithinNestedConnections | 20097917 | 20097917 | 2334 | 2364 | 2008534 | | aggregations.NestedCountFromMovieToActors | 8603 | 8603 | 36 | 50 | 2174 | | aggregations.NestedCountFromActorsToMovie | 8791 | 8791 | 38 | 44 | 2174 | | aggregations.DeeplyNestedCount | 10052335 | 10052335 | 2327 | 2766 | 2008534 | | aggregations.InterfacesAggregations | 6242 | 6242 | 47 | 72 | 2080 | | aggregations.InterfacesAggregationsWithTwoFields | 11444 | 11444 | 81 | 120 | 2080 | | batch-create.BatchCreate | 4200 | 4200 | 128 | 190 | 600 | | batch-create.BatchCreateSmall | 77 | 77 | 57 | 71 | 11 | | connect.createAndConnect | 6433 | 6433 | 131 | 177 | 3003 | | connections.Connection | 12951 | 12951 | 64 | 77 | 2174 | | connections.NestedConnection | 37705 | 37705 | 135 | 141 | 4516 | | create.SimpleMutation | 7 | 7 | 58 | 61 | 1 | | cypher-directive.TopLevelMutationDirective | 1135 | 1135 | 29 | 30 | 1134 | | delete.SimpleDelete | 19401 | 19401 | 671 | 677 | 1040 | | delete.NestedDeleteInUpdate | 16844 | 16844 | 121 | 161 | 1183 | | 2871.NestedRelationshipFilter | 19632 | 19632 | 55 | 86 | 4395 | | 2925.SingleRelationshipFilter | 5245 | 5245 | 41 | 66 | 1040 | | 2925.NestedSingleRelationshipFilter | 17641 | 17641 | 84 | 175 | 2174 | | 2925.SingleRelationshipRequiredFilter | 5201 | 5201 | 39 | 51 | 1040 | | 2925.NestedSingleRelationshipRequiredFilter | 9361 | 9361 | 58 | 82 | 1040 | | query.SimpleQuery | 3121 | 3121 | 22 | 25 | 1040 | | query.SimpleQueryWithRelationship | 15031 | 15031 | 44 | 45 | 2174 | | query.QueryWhere | 8564 | 8564 | 37 | 38 | 2154 | | query.SimpleQueryWithNestedWhere | 8713 | 8713 | 49 | 56 | 2154 | | query.Nested | 10084891 | 10084891 | 7140 | 7405 | 2008534 | | query.NestedWithFilter | 10064992 | 10064992 | 7577 | 7063 | 2004000 | | query.OrFilterOnRelationships | 36670 | 36482 | 169 | 173 | 1935 | | query.OrFilterOnRelationshipsAndNested | 26743 | 26913 | 195 | 315 | 1935 | | query.QueryWithNestedIn | 14129 | 14129 | 53 | 68 | 1843 | | query.NestedConnectionWhere | 8703 | 8703 | 55 | 71 | 2174 | | query.DeeplyNestedConnectionWhere | 8702 | 8702 | 75 | 97 | 2174 | | query.DeeplyNestedWithRelationshipFilters | 17357 | 17357 | 128 | 156 | 1552 | | query.NestedWithRelationshipSingleFilters | 3808 | 3808 | 146 | 193 | 1134 | | query.Fulltext | 64 | 64 | 34 | 39 | 16 | | query.FulltextWithNestedQuery | 516 | 516 | 45 | 52 | 84 | | sorting-and-cypher.TopLevelSortWithCypher | 12961 | 12961 | 75 | 50 | 2174 | | sorting-and-cypher.TopLevelConnectionSortWithCypher | 12961 | 12961 | 63 | 71 | 2174 | | sorting-and-cypher.TopLevelSortWithCypherWithNested | 13096 | 13096 | 57 | 81 | 2174 | | sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested | 13096 | 13096 | 107 | 109 | 2174 | | sorting-and-cypher.TopLevelSortWithExpensiveCypher | 13725 | 13725 | 104 | 133 | 2174 | | sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher | 13266 | 13266 | 102 | 146 | 2174 | | sorting.SortMultipleTypes | 3436 | 3436 | 86 | 101 | 1040 | | sorting.SortMultipleTypesWithCypherWithCypher | 13321 | 13321 | 109 | 125 | 2174 | | sorting.SortOnNestedFields | 12951 | 12951 | 45 | 57 | 2174 | | sorting.SortDeeplyNestedFields | 39785 | 39785 | 80 | 103 | 4516 | | sorting.ConnectionWithSort | 3271 | 3271 | 76 | 83 | 1040 | | unions.SimpleUnionQuery | 321 | 321 | 66 | 71 | 35 | | unions.SimpleUnionQueryWithMissingFields | 293 | 293 | 56 | 66 | 35 | | unions.NestedUnion | 309975 | 309975 | 293 | 284 | 33033 | | unions.NestedUnionWithMissingFields | 283949 | 283949 | 270 | 298 | 33033 | | update.NestedUpdate | 14137 | 14137 | 113 | 139 | 2002 |

Old Schema Generation: 29.567s Schema Generation: 29.534s Old Subgraph Schema Generation: 30.812s Subgraph Schema Generation: 31.305s