neo4j / helm-charts

Apache License 2.0
59 stars 53 forks source link

[Bug]: Minimum cluster size forced to be >= 3 #150

Closed rlch closed 1 year ago

rlch commented 1 year ago

Contact Details

No response

What happened?

Hi,

I've noticed that clustering is only enabled when neo4j.minimumClusterSize is greater than or equal to 3:

{{- define "neo4j.isClusterEnabled" -}}
      {{- $minClusterSize := index $.Values.neo4j "minimumClusterSize" | default 1 | int -}}
      {{- if ge $minClusterSize 3 -}}
          {{- if not (eq $.Values.neo4j.edition "enterprise") -}}
               {{- fail (printf "Please use enterprise edition for clustering. You can set edition via --set neo4j.edition=enterprise") -}}
          {{- end -}}
            true
      {{- else -}}
            false
      {{- end -}}
  {{- end -}}

Is this intended? I haven't found docs for Neo4J 5.x that state this as a constraint. Thanks

Note: The Chart Version and Chart Name for the issue template has not been updated for 5.x. I'm running the latest 5.5.0.

Chart Name

neo4j

Chart Version

5.5.0

Environment

Google Cloud Platform

Relevant log output

No response

Code of Conduct

harshitsinghvi22 commented 1 year ago

hi @rlch the minimum number of members for a fault tolerant cluster is 3 hence the condition https://github.com/neo4j/helm-charts/blob/5.5.0/neo4j/Chart.yaml The chart version and chart name are correct

rlch commented 1 year ago

Thank you!

rlch commented 1 year ago

@harshitsinghvi22 Was referring to the issue template, but no big deal: image

harshitsinghvi22 commented 1 year ago

ahh thanks for reporting that let me fix it now