neo4j / neo4j-browser

Neo4j Browser is the general purpose user interface for working with Neo4j. Query, visualize, administrate and monitor the database.
https://neo4j.com
GNU General Public License v3.0
690 stars 347 forks source link

Update `.nvmrc` to use 'lts/gallium' #1921

Open luchillo17 opened 1 year ago

luchillo17 commented 1 year ago

Description

Installing with nvm install uses the .nvmrc version, which is currently set to 16.10.0, this gives errors when installing.

Reproduce Steps

Expected Behavior

Nvm installs Node without any issues.

Current Behavior

Errors out complaining about Python 3.10

2023-06-03_02h52_38

Can you propose a solution?

I would recommend changing this to the LTS version lts/gallium or at least updating to 16.20.0.

Your Environment

image

software name version
OS Windows 10 WSL2 Ubuntu
Web browser Chrome
node.js None before install
npm -
yarn -
Neo4j Browser Cloned repo master branch
Neo4j -

Additional Information

The Readme mentions Node v12, we should update that as well.

OskarDamkjaer commented 1 year ago

I didn't know the installation could break by having python installed, interesting! We used to have a later version of 16, but I remember there was some issue with either jest or similar. Ideally we'd move to node 18, since it's the latest LTS. I'll investigate

Thanks for taking the time to report this issue and add a solution!

OskarDamkjaer commented 1 year ago

Ah yes here it was https://github.com/neo4j/neo4j-browser/pull/1820

luchillo17 commented 1 year ago

Hmm then maybe it's better to mention the specific Python version limit until that gets fixed?

OskarDamkjaer commented 1 year ago

I think the best would be to both update node and migrate away from webpack & jest to vite and vitest, but I don't think we well do that anytime soon. Mentioning the python issue is better than nothing in the mean time